Fix: several typos in the documentation #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoobie
requested changes
Nov 15, 2023
...nents/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/cairo-and-sierra.adoc
Outdated
Show resolved
Hide resolved
components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-abi.adoc
Outdated
Show resolved
Hide resolved
| @@ -70,7 +70,7 @@ When working with the CLI, you can manually set the endpoints for the gateways t | |||
| interact with Starknet, by including the following options: | |||
|
|
|||
| `--feeder_gateway_url`:: Sets the custom endpoint for read commands. | |||
| `--gateway_url`:: Sets the custom endpoint for write commands. | |||
| `--gateway_url`:: Sets the custom endpoint for writing commands. | |||
There was a problem hiding this comment.
This change is incorrect. The sentence is talking about read/write commands.
components/Starknet/modules/quick_start/pages/declare_a_smart_contract.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Goodman <[email protected]>
Co-authored-by: Steve Goodman <[email protected]>
Co-authored-by: Steve Goodman <[email protected]>
Co-authored-by: Steve Goodman <[email protected]>
|
hello @stoobie i didn t see the notification 3 days ago, check now please. Thanks ! |
stoobie
reviewed
Nov 16, 2023
components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-abi.adoc
Outdated
Show resolved
Hide resolved
…art_Contracts/contract-abi.adoc
stoobie
merged commit 2553f91
into
starknet-io:tudorpintea999/fix-typo
1 of 2 checks passed
|
Merged to new branch to generate preview before merging to dev. |
2 tasks
stoobie
added a commit
that referenced
this pull request
Nov 17, 2023
* Fix: several typos in the documentation (#929) * Update cairo-and-sierra.adoc * Update contract-abi.adoc * Update contract-address.adoc * Update contract-classes.adoc * Update contract-storage.adoc * Update hash-functions.adoc * Update starknet-state.adoc * Update starkli.adoc * Update declare_a_smart_contract.adoc * Update juno_versions.adoc * Update pathfinder_versions.adoc * fix typo doc_guidelines.adoc * fix contract-abi.adoc Co-authored-by: Steve Goodman <[email protected]> * fix starkli.adoc Co-authored-by: Steve Goodman <[email protected]> * fix declare_a_smart_contract.adoc Co-authored-by: Steve Goodman <[email protected]> * fix doc_guidelines.adoc Co-authored-by: Steve Goodman <[email protected]> * Update starkli.adoc * Update cairo-and-sierra.adoc * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-abi.adoc --------- Co-authored-by: Steve Goodman <[email protected]> * Apply suggestions from code review --------- Co-authored-by: iwantanode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Hello
I fixed some typos in the docs,
Hope it helps.
Br,
Tudor.
This change is